relaxing tolerances to fix failing test #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/relax-tol
branch
4 times, most recently
from
ab3c6b9
to
52ddbe3
Compare
|
Interestingly, I can't seem to reproduce the problem even with the same 0.21.1 sklearn version on my own machine. |
imatiach-msft
force-pushed
the
ilmat/relax-tol
branch
from
fdabc81
to
35ba078
Compare
imatiach-msft
changed the title
|
@slundberg I was able to reproduce the issue on an ubuntu machine. Relaxing the tolerance seems to have fixed it. Strangely, downgrading scikit-learn did not fix the issue on the machine, so I'm not sure why the results were so different. Increasing the l1 regularization parameter for kernel explainer also fixed the issue. |
imatiach-msft
force-pushed
the
ilmat/relax-tol
branch
from
35ba078
to
86ddf75
Compare
|
Thanks! I expect to be back here covering issues etc by next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] scikit learn was recently upgraded which may be causing some test failures due to precision of test assertions. Relaxing the tolerance to see if it will fix the test.