Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more logging #32

Merged
merged 2 commits into from
Jun 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import Combine
import Foundation
import LogHelpers
import OSLog
import Tart
import TartDirectoryHelpers
import VirtualMachine
Expand All @@ -17,6 +19,7 @@ public final class EphemeralTartVirtualMachine: VirtualMachine {
private let resourcesDirectoryURL: URL
private let onCleanup: CleanupHandler
private var runTask: Task<(), Error>?
private let logger = Logger(category: "EphemeralTartVirtualMachine")

public init(
tart: Tart,
Expand All @@ -36,8 +39,13 @@ public final class EphemeralTartVirtualMachine: VirtualMachine {
defer {
onCleanup()
}
let sourceVMName = sourceVMName
let destinationVMName = destinationVMName
logger.info("Clone Tart image named \(sourceVMName, privacy: .public) to \(destinationVMName, privacy: .public)...")
try await tart.clone(sourceName: sourceVMName, newName: destinationVMName)
logger.info("Run Tart image named \(destinationVMName, privacy: .public)...")
try await tart.run(name: destinationVMName, mounting: [.resources(at: resourcesDirectoryURL)])
logger.info("Delete Tart image named \(destinationVMName, privacy: .public)...")
try await tart.delete(name: destinationVMName)
onCleanup()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ private extension VirtualMachineFleetLive {
} else {
logger.info("Task running virtual machine named \(name, privacy: .public) was cancelled.")
}
logger.info("Task running virtual machine named \(name, privacy: .public) was cancelled.")
}
activeTasks.append(task)
}
Expand Down
Loading