Fixes bug when colon character is in virtual machine name #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbernson
reviewed
Aug 3, 2023
| @@ -61,6 +61,7 @@ public struct VirtualMachineResourcesServiceEphemeral: VirtualMachineResourcesSe | |||
| } | |||
|
|
|||
| public func createResourcesIfNeeded() async throws { | |||
| return; | |||
There was a problem hiding this comment.
The code underneath this return statement will never be executed anymore. Is this a line left in by accident after debugging?
There was a problem hiding this comment.
Yes, this was left in by accident. I removed the return statement.
stmitt
force-pushed
the
bugfix/replace-colons-in-vm-name
branch
from
1140776
to
48c0e54
Compare
simonbs
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #38. The colon character is used as a separator in tart's share command.