New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding safeguards to avoid failing corner cases in Visvalingam #157

Open

avilchess wants to merge 1 commit into master from fix/visvalingam

Contributor

avilchess commented Jul 30, 2020

Make sure you have checked all steps below.

Description

Here are some details about my PR, including screenshots of any UI changes:

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

License

Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

In case of new functionality, my PR adds documentation that describes how to use it.


          Adding safeguards to avoid failing corner cases

e8dd422

avilchess assigned avilchess, jrecuerda and raulbocanegra and unassigned avilchess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment