BUG: fix Polygon() constructor from a LineString

shapely · Dec 29, 2021 · 16ed417 · 16ed417
1 parent 48cf81e
commit 16ed417
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/shapely/geometry/polygon.py b/shapely/geometry/polygon.py
@@ -238,6 +238,9 @@ def __new__(self, shell=None, holes=None):
                 # conversion of coords to 2D array failed, this might be due
                 # to inconsistent coordinate dimensionality
                 raise ValueError("Inconsistent coordinate dimensionality")
+        else:
+            if not isinstance(shell, LinearRing):
+                shell = LinearRing(shell)
 
         geom = shapely.polygons(shell, holes=holes)
         if not isinstance(geom, Polygon):

diff --git a/shapely/tests/geometry/test_polygon.py b/shapely/tests/geometry/test_polygon.py
@@ -173,6 +173,18 @@ def test_polygon_from_linearring():
         assert polygon.interiors[i].coords[:] == holes[i].coords[:]
 
 
+def test_polygon_from_linestring():
+    coords = [(0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (0.0, 0.0)]
+    line = LineString(coords)
+    polygon = Polygon(line)
+    assert polygon.exterior.coords[:] == coords
+
+    # from unclosed linestring
+    line = LineString(coords[:-1])
+    polygon = Polygon(line)
+    assert polygon.exterior.coords[:] == coords
+
+
 def test_polygon_from_polygon():
     coords = [(0.0, 0.0), (0.0, 1.0), (1.0, 1.0), (1.0, 0.0)]
     polygon = Polygon(coords, [((0.25, 0.25), (0.25, 0.5), (0.5, 0.5), (0.5, 0.25))])