Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add more tests for new query_items #1171

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

jorisvandenbossche
Copy link
Member

Another follow-up on #1112. Some aspects of the new query_items were not yet covered in the tests:

  • constructing the STRtree with explicit items sequence + using query_items without providing explicit items (so using a default enumeration index then)
  • testing that the returned item is still correct if some geometries were dropped before constructing the GEOS tree

"""Store enumeration idx"""
with pytest.warns(ShapelyDeprecationWarning):
tree = STRtree(geoms, items)
results = tree.query_items(query_geom)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a version of the test above, but with different options for items

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.286% when pulling 10a5553 on jorisvandenbossche:strtree-tests into a228836 on Toblerity:master.

Copy link
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sgillies sgillies merged commit 9a76173 into shapely:master Jul 26, 2021
@jorisvandenbossche jorisvandenbossche deleted the strtree-tests branch August 3, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants