Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError for non-finite distance to buffer/parallel_offset (maint-1.8) #1516

Merged
merged 1 commit into from Sep 2, 2022
Merged

Raise ValueError for non-finite distance to buffer/parallel_offset (maint-1.8) #1516

merged 1 commit into from Sep 2, 2022

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Sep 1, 2022 •
edited by jorisvandenbossche

Fixes #1483 and fixes #1515 for the shapely 1.8.x maintenance branch.

I'll apply a similar approach for the main branch soon (sometime after #1514 is merged).

@mwtoews mwtoews added this to the 1.8.5 milestone Sep 1, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2975711931

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.865%
Totals Coverage Status
Change from base Build 2878254665: 0.02%
Covered Lines: 3019
Relevant Lines: 3516
💛 - Coveralls

@jorisvandenbossche jorisvandenbossche merged commit 6613610 into shapely:maint-1.8 Sep 2, 2022
@jorisvandenbossche
Copy link
Member

Thanks!

I'll apply a similar approach for the main branch soon (sometime after #1514 is merged).

See also #1483 (comment), it might be that we only need to add tests on the main branch

@mwtoews mwtoews deleted the non-finite-distance-maint-1.8 branch September 5, 2022 07:27
@mwtoews mwtoews mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwtoews @coveralls @jorisvandenbossche