Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: flake8 has migrated to GH – update .pre-commit #1614

Merged
merged 1 commit into from
Nov 21, 2022
Merged

CI: flake8 has migrated to GH – update .pre-commit #1614

merged 1 commit into from
Nov 21, 2022

Conversation

jGaboardi
Copy link
Contributor

flake8 has migrated from GitLab to GitHub, causing the pre-commit hook & linting to fail. This PR updates .pre-commit-config.yml.

xref geopandas/geopandas#2651 (piggybacking @rraymondgh's PR)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3479916636

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.914%
Totals Coverage Status
Change from base Build 3477517468: 0.0%
Covered Lines: 2212
Relevant Lines: 2605
💛 - Coveralls

@jGaboardi jGaboardi mentioned this pull request Nov 18, 2022
Merged
@jules-ch jules-ch mentioned this pull request Nov 21, 2022
Closed
jorisvandenbossche
jorisvandenbossche approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jorisvandenbossche jorisvandenbossche changed the title flake8 has migrated to GH – update .pre-commit CI: flake8 has migrated to GH – update .pre-commit Nov 21, 2022
@jorisvandenbossche jorisvandenbossche merged commit a836ad0 into shapely:main Nov 21, 2022
@jGaboardi jGaboardi deleted the flake8_github branch November 21, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jGaboardi @coveralls @jorisvandenbossche