REGR: fix __eq__ to not ignore z values #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
approved these changes
Jun 26, 2023
Comment on lines
+70
to
+81
| all_types_z = ( | ||
| point_z, | ||
| line_string_z, | ||
| polygon_z, | ||
| multi_point_z, | ||
| multi_line_string_z, | ||
| multi_polygon_z, | ||
| polygon_with_hole_z, | ||
| geometry_collection_z, | ||
| empty_point_z, | ||
| empty_line_string_z, | ||
| ) |
There was a problem hiding this comment.
I have a draft PR with some very similar items, but I'll work with this version to start with.
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Pull Request Test Coverage Report for Build 5630011376Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1732
Broken off from #1760, to just restore the previous behaviour (using the previous implementaiton) and already add the more extensive tests that I wrote for that PR. This way, the other PR can focus more on the API change.