fixes #91: allow secure variant of scheme when only insecure is given #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Initial once-over looks good. I'll do a more detailed review soon. |
| resource.scheme.equalsIgnoreCase(shpOrigin.scheme); | ||
| } else { | ||
| schemeMatches = this.scheme.equalsIgnoreCase(resource.scheme); | ||
| if (resource.isNetworkScheme() && !resource.scheme.equalsIgnoreCase("ftp") && !this.scheme.equalsIgnoreCase("ftp")) { |
There was a problem hiding this comment.
I can't find the reason for this ftp exception.
There was a problem hiding this comment.
We don't want to match ftp to any other network scheme.
shekyan
force-pushed
the
GH-91
branch
3 times, most recently
from
4bd7b3e
to
02c2f69
Compare
|
@shekyan LGTM. But you either need to sign the CLA with your personal email address or amend your commit with your work email. |
|
@michaelficarra, that's strange. My both email addresses are in CLA for ages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.