Added test262 tests #312
Merged
Added test262 tests #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI has failed. Also, for each excluded test, can you link to the appropriate issue (and create it if it does not yet exist)? |
Shilpi3
force-pushed
the
add-test262-tests
branch
4 times, most recently
from
e77862f
to
8a7d74a
Compare
| suite('early', function() { | ||
| var earlyExcludes = ['56.script.js', '88.script.js', '90.script.js', '190.script.js' ,'205.script.js','557.script.js', '558.script.js', '559.script.js', '560.script.js', '561.script.js', '563.script.js', '564.script.js', '565.script.js', '566.script.js', '567.script.js', '568.script.js', '569.script.js', '570.script.js', '571.script.js', '572.script.js', '574.script.js', '575.script.js', '576.script.js', '577.script.js', '578.script.js', '579.script.js', '580.script.js', '581.script.js', '582.script.js', '583.script.js', '585.script.js', '586.script.js', '587.script.js', '588.script.js', '589.script.js', '590.script.js', '591.script.js', '592.script.js', '593.script.js', '594.script.js', '596.script.js', '597.script.js', '598.script.js', '599.script.js', '600.script.js', '601.script.js', '602.script.js', '641.script.js', '642.script.js']; | ||
|
|
||
| fs.readdirSync(scriptDir + '/early').filter(function(item) { return earlyExcludes.indexOf(item) === -1 }).forEach(function(f) { |
Shilpi3
force-pushed
the
add-test262-tests
branch
2 times, most recently
from
5fa0c51
to
a6f9cd6
Compare
michaelficarra
requested changes
Jan 13, 2017
| let scriptDir = 'node_modules/test262-parser-tests'; | ||
|
|
||
| function parse(src, isModule, earlyErrors) { | ||
| (isModule ? parseModule : parseScript)(src, { earlyErrors: earlyErrors }); |
|
|
||
| suite('test262', function () { | ||
| suite('pass and pass-explicit', function () { | ||
| let passExcludes = ['995.script.js', // https://github.com/shapesecurity/shift-parser-js/issues/311 |
| suite('pass and pass-explicit', function () { | ||
| let passExcludes = ['995.script.js', // https://github.com/shapesecurity/shift-parser-js/issues/311 | ||
| '970.script.js', // This is an invalid test | ||
| '1012.script.js']; // https://github.com/shapesecurity/shift-parser-js/issues/311 |
| expect(function parsePass() { | ||
| passTree = parse( | ||
| fs.readFileSync(scriptDir + '/pass/' + f, 'utf8'), | ||
| f.match('.module.js'), |
There was a problem hiding this comment.
This indentation. Please not like this. 2 space indentation, always. All arguments should be at the same level.
| '589.script.js', '590.script.js', '591.script.js', '592.script.js', '593.script.js', | ||
| // https://github.com/shapesecurity/shift-parser-js/issues/307 | ||
| '594.script.js', '596.script.js', '597.script.js', '598.script.js', | ||
| '599.script.js', '600.script.js', '601.script.js', '602.script.js']; // causes Syntax Errors in the test script |
There was a problem hiding this comment.
To which script is this comment referring? Please place it more appropriately. And of course, newline before ].
Shilpi3
force-pushed
the
add-test262-tests
branch
2 times, most recently
from
54c77e5
to
883f81f
Compare
michaelficarra
approved these changes
Jan 13, 2017
Shilpi3
force-pushed
the
add-test262-tests
branch
from
883f81f
to
794afdc
Compare
Excluded failed tests
Shilpi3
force-pushed
the
add-test262-tests
branch
3 times, most recently
from
1533b2e
to
f4ec725
Compare
Shilpi3
force-pushed
the
add-test262-tests
branch
from
f4ec725
to
3b9aa13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluded failed Tests. Relates to #311 #313 #314