Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support cosmos and thorchain when validating current app on ledger device #670

Merged
merged 4 commits into from
May 9, 2024
Merged

fix: support cosmos and thorchain when validating current app on ledger device #670

merged 4 commits into from
May 9, 2024
+95 −83

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented May 9, 2024 •
edited

Adds support for checking the status of the current app on ledger for Cosmos and THORChain.

Removes some dead code.

Relates to shapeshift/web#6806

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:55pm

@woodenfurniture woodenfurniture changed the title fix: support cosmos and thorchain when validating current app on ledg… fix: support cosmos and thorchain when validating current app on ledger device May 9, 2024
@woodenfurniture woodenfurniture mentioned this pull request May 9, 2024
Closed
gomesalexandre
gomesalexandre previously approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed this does what it says on the box

Screen.Recording.2024-05-09.at.08.50.23.mov

@woodenfurniture woodenfurniture marked this pull request as ready for review May 9, 2024 06:59
@woodenfurniture woodenfurniture requested a review from a team as a code owner May 9, 2024 06:59
gomesalexandre
gomesalexandre previously approved these changes May 9, 2024
View reviewed changes
@gomesalexandre gomesalexandre force-pushed the cosmos-thorchain-ledger-app-validation branch from 6b59914 to d422241 Compare May 9, 2024 16:28
@gomesalexandre gomesalexandre force-pushed the cosmos-thorchain-ledger-app-validation branch from d422241 to fe62f94 Compare May 9, 2024 16:41
@gomesalexandre gomesalexandre force-pushed the cosmos-thorchain-ledger-app-validation branch from fe62f94 to 2d07773 Compare May 9, 2024 16:46
@gomesalexandre gomesalexandre merged commit 68f51dc into master May 9, 2024
6 checks passed
@gomesalexandre gomesalexandre deleted the cosmos-thorchain-ledger-app-validation branch May 9, 2024 17:45
@gomesalexandre gomesalexandre mentioned this pull request May 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woodenfurniture @gomesalexandre @kaladinlight