-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding kube prometheus monitoring stack #703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to clarify, does the kube prometheus actually deploy grafana/loki/prometheus, or just bundle grafana dashboard views and different alerts? |
It's the full stack. Prometheus operator, node exporter, grafana, alert manager plus some nice default dashboards and alerts |
This reverts commit e31484e.
kaladinlight
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new monitoring setup, which primarily replaces our existing infrastructure setup. Instead of deploying everything via Pulumi, we utilize a different tool for setting up this part of the infrastructure configuration with a dedicated tool called kube-prometheus.
This middle-ground solution allows us to tweak most of the settings more easily and use built-in configuration options. For things that are not covered by the tool, we still depend on the Pulumi stack, such as the Traeffic ingress or any additional stuff that's easier to do via Pulumi.
Changes performed:
kube-prometheus
does not offer diff functionality similar to Pulumi, we depend onkubectl diff
to preview the changes to be made to our stackCloses #700