Consolidate Tx building into a common util over all THOR domains

[gomesalexandre]

Overview

See this most recent guy which is nice and clean, properly switching over chains/Tx types to build a depositWithExpiryTx:

web/src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx

Line 466 in c4c9f4f

const handleSignTx = useCallback(() => {

We want to abstract this switching logic away into some helper function, to ensure:

1. We avoid bugs related to e.g token Txs not being implemented
2. We consistently call depositWithExpiry() when applicable i.e for EVMs, ensuring expiry is properly set, and facilitating Tx history parsing

References and additional details

web/src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx

Line 466 in c4c9f4f

const handleSignTx = useCallback(() => {

Acceptance Criteria

• We have some common util for building THOR Txs with a "per-chain", or to be exact, per Tx type i.e:

  • EvmCustomTx - depositWithExpiry()
  • MsgDeposit - RUNE LP and Swap Txs
  • Send - actual sends

• EVM transactions leverage EIP1559 if supported otherwise create legacy transactions

  • lib/utils/evm.ts was meant to be a common utility for creating evm transactions with the appropriate gas fees. utilize if possible or think of a good way to capsulate reusable evm fee logic that can be used for thorchain txs or elsewhere in the app

• This is propagated over all THOR domains whenever applicable:

  • LP (the source of truth for this logic)
  • Savers
  • Lending
  • Swaps (if applicable)

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response