feat: consolidate thor logic

[gomesalexandre]

Description

This PR extracts the Tx building logic into a common THOR hook - consuming it in THORChain LP as a first step everywhere.

See #6708 and #6729 for the granular PRs that implement lending and savers and their own testing steps

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

• closes Consolidate Tx building into a common util over all THOR domains #6683

Risk

High Risk PRs Require 2 approvals

High, touches THORChain LP, lending and savers

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Regression test the following for LP:

• sym/asym deposits and withdraws
• At least one EVM native asset and EVM token for each of the above
• At least one non-EVM asset for each of the above

Refer to the #6708 and #6729 tickets for lending and savers testing.

Engineering

• ^

Operations

• ^

Screenshots (if applicable)

• Asym token deposit

• Asym token withdraw (disregard the error, the unsafe minimum has been monkey patched to test this)

• Asym native EVM asset deposit

• Asym native EVM asset withdraw

• Asym RUNE deposit

• Asym RUNE withdraw

• Sym EVM native asset deposit

• Sym EVM native asset withdraw

[gomesalexandre]

Opening for early review and discussion - while this is already working and wired up for THORChain LP, happy to discuss the API some more here before we get this in, since this is eventually going to be consumed by all THORChain LP domains.

[woodenfurniture]

Teting notes

LP

🚫 Blank screen on click "add liquidity" button

Screen.Recording.2024-05-01.at.7.36.46.AM.mov

---

🚫 (May not be a regression) text on confirmation says "Transaction submitted" instead of "Transaction confirmed"

---

🚫 (Possibly related to the above) text after confirming still says "Waiting for confirmation" instead of "Transaction submitted"

Screen.Recording.2024-05-01.at.8.47.03.AM.mov

---

Add liquidity - non EVM

✅ Native deposit https://viewblock.io/thorchain/tx/390bc58d599f0e4672809e1d7a46fffb6937506f15f42df47405b162614a5aa6

---

✅ Rune deposit https://viewblock.io/thorchain/tx/9E89C1C93A271EB5AE43959C7474B07B339B1D6B544824D8BAB96C26BA0D9E89

---

TODO: Sym deposit

---

Add liquidity - Native EVM

✅ Asym deposit
https://viewblock.io/thorchain/tx/8b896aa5454a8a3cbbfdca23c2020354f9ee3513a285abeccaa85c347bfb65fc

---

🚫 ~Sym deposit - stuck after rune side completes. ~ link to issue #6787
https://viewblock.io/thorchain/tx/9283E5816B31A73A37D1009B456EFD8A76D869ED446B6790711FDFC53326E739

This issue looks unrelated to this PR because it seems to be an issue where we arent able to prevent conflicting deposit types across tabs. The following message appeared after sym rune deposit - but there was already a sym deposit in flight in a different tab... The seems to warrant some discussion.

---

✅ Rune asym deposit https://viewblock.io/thorchain/tx/4B368941F763628989260E328D0FC3C41C297A82882448D86C506CB1308DC577

---

Remove liquidity

✅ Remove liquidity - sym non-EVM https://viewblock.io/thorchain/tx/CECA6B5850A95DD1B9DB94A672A02A77CFC00D04D717A903C02153911F516B22

---

TODO: Remove liquidity - asym non-EVM (RUNE)

---

TODO: Remove liquidity - asym non-EVM (DOGE)

---

✅ Remove liquidity - asym EVM (AVAX) https://viewblock.io/thorchain/tx/011417992033214ba9550d4cdad67e2f8f71bf2451107f64aa35731f4774885a

---

✅ Remove liquidity - asym EVM (AVAX) https://viewblock.io/thorchain/tx/28663DE796B9F30B55E52FCC3C479536EE29AC4B16B72D181A4A16FD4A8CF066

---

TODO: Remove liquidity - asym EVM (RUNE)

---

TODO: add/remove liquidity for non-native EVM sym/asym/rune

Other / Paranoia

✅ ETH -> AVAX bridge
✅ ETH -> RUNE bridge
✅ ETH -> DOGE bridge