Users unable to pass approval step in LINK asym pool deposits #6775
Comments
purelycrickets
added
bug
|
@purelycrickets did I hear you mention that you were able to replicate this on the THORSwap UI as well? |
|
@purelycrickets I wasn't able to repro on THORSwap nor in the app - is this still happening? link.movGut feel if this was happening both with us and THORswap is there may have been an upstream issue re: inbound addresses rotation, it would help to see at least two of those Txids to see if they approved LINK for the same spender. |
|
User was able to recreate in thorswap when it was first posted, but also is no longer seeing the issue now. Thanks for the explanation @gomesalexandre. Here are the TXIDs of the multiple approvals i made testing if it helps any: |
|
Last one looks like it's not related to THOR and was probably inluded by mistake, but all the others look sane to me and approved the same contract as spender. Unless this is reproducible in prod currently and after the THOR consolidation PR, I would probably disregard THORSwap having the same issue (doesn't look like anything's wrong here Tx-wise) and assume we had some shenanigans on allowance checks which are now fixed, close this, and possibly reopen if that ever happens again and ops can consistently repro @purelycrickets |
|
This issue is persistent and repeatable. Every time. It is NOT resolved. Please acknowledge. |
|
|
|
I just tried to deposit LINK into the Pool again. I'm using a Trezor One to connect and transact. Earlier just now, I deposited into the BTC/RUNE Pool without any issue. There is a conflict with only LINK when I try it. I've been successful before. My last LINK deposit was on 27 APR. |
Hey @RussellJBennett are you trying on ShapeShift? It appears you are sharing screenshots from Thorswap, an app we have no control over the codebase of. |
|
"If it doesn’t work in THORswap, why would we expect a different result in Shapeshift?" Thorswap and ShapeShift are two separate front end interfaces. We manage ShapeShift, another team manages Thorswap. Both teams have integrated THORchain, however the code bases are different and we do not have the ability to control the code at Thorswap. We believe the issue will be resolved if you attempt the action at ShapeShift. You may want to open up the issue with THORswap if you wish to see the issue fixed there as well. |
|
Don't "believe the issue will be resolved if you attempt the action at ShapeShift" Test it. Then show me evidence it's resolved. I'm not interested in being a beta tester for ShapeShift's front end. |
|
ShapeShift has resolved this issue. Please close my incident. Thx, Russell |
Overview
Currently in production, Users are unable to get past the approval section in an asym deposit of LINK into a pool. The user is continually prompted to approve and can continually spend gas on approvals without error messages or being able to move forward to their desired action.
References and additional details
Screen recording of the approval flow coninually prompting:
https://github.com/shapeshift/web/assets/94998097/21d6a13f-7c0d-43e8-b4b9-d6e3d8032207
Previous recording was too long to upload, heres a screenshot of the multiple approvals paid without the flow continuing:
Acceptance Criteria
Users are able to complete the desired flow of LINK asym deposits, or ShapeShift is able to handle errors experienced upstream in TC that could block users from coniuning their desired action.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: