feat: revert of the revert of "fix(UserMenu): locked metamask not rec… #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Deploying with
|
| Latest commit: |
e338f4c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd6fb424.web-29e.pages.dev |
|
@brymut are you able to take a look at this please? we had to back #1667 out of develop as it caused regressions, and develop was not able to connect to metamask. this hdwallet PR was just merged to publish a new version shapeshift/hdwallet#530 you'll need to update to hdwallet |
|
@0xdef1cafe Pushed bumped hdwallet packages to latest and gave it one more test connecting/waiting for auto-lock, works just as when I was linking hdwallet-metamask |
|
tested working by ops as per https://discord.com/channels/554694662431178782/974442760247578664/974800402786689045 |
0xdef1cafe
approved these changes
May 13, 2022
0xApotheosis
approved these changes
May 13, 2022
|
yeah gave this another thorough test myself, everything behaves as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnecting (#1667)"
a.k.a the revert of the revert
Requires shapeshift/hdwallet#528 to be published before, and hdwallet deps updated before this goes to review.
Description
Added a button group to separate the dropdown button while wallet is stuck in a loading state when Metamask is locked
Notice
Pull Request Type
Issue (if applicable)
closes #1262
Risk
Testing
Screenshots (if applicable)
Test.locked.mm.mov