-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused error handling & misc. fixes #1830
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…rade after approval occurs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with comments - please click accept on suggestions and i'll restamp
Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
done. If only this cypress test would pass |
I had to undo those changes. it doesnt quite fit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
Description
Notice
Pull Request Type
Issue (if applicable)
Risk
Low risk. fixes a couple swapper regressions and general cleanup
Testing
See that you cant click through a trade with 0 amount entered.
See that swapping is not borked in general
Screenshots (if applicable)