Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused error handling & misc. fixes #1830

Merged
merged 9 commits into from
May 18, 2022

Conversation

elmutt
Copy link
Collaborator

@elmutt elmutt commented May 18, 2022

Description

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Low risk. fixes a couple swapper regressions and general cleanup

Testing

See that you cant click through a trade with 0 amount entered.
See that swapping is not borked in general

Screenshots (if applicable)

Screen Shot 2022-05-18 at 3 20 45 PM

@elmutt elmutt requested review from a team and 0xApotheosis as code owners May 18, 2022 21:27
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 18, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46cdf70
Status: ✅  Deploy successful!
Preview URL: https://4cb51fa2.web-29e.pages.dev

View logs

Copy link
Contributor

@theoboldfrazier theoboldfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elmutt elmutt changed the title chore: remove unused error handling code and make less api calls chore: remove unused error handling & misc. fixes May 18, 2022
0xdef1cafe
0xdef1cafe previously approved these changes May 18, 2022
Copy link
Collaborator

@0xdef1cafe 0xdef1cafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments - please click accept on suggestions and i'll restamp

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
0xdef1cafe
0xdef1cafe previously approved these changes May 18, 2022
@elmutt
Copy link
Collaborator Author

elmutt commented May 18, 2022

approved with comments - please click accept on suggestions and i'll restamp

done. If only this cypress test would pass

@elmutt
Copy link
Collaborator Author

elmutt commented May 18, 2022

approved with comments - please click accept on suggestions and i'll restamp

I had to undo those changes. it doesnt quite fit

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍭

src/components/Approval/Approval.tsx Show resolved Hide resolved
@0xApotheosis 0xApotheosis merged commit becb396 into develop May 18, 2022
@0xApotheosis 0xApotheosis deleted the swapper_cleanup_errors branch May 18, 2022 23:13
@elmutt elmutt linked an issue May 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants