feat: switch chain to mainnet on wallet re/connect #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
changed the title
gomesalexandre
commented
Jun 28, 2022
|
Moving to draft until new hdwallet version is published. |
0xdef1cafe
reviewed
Jun 29, 2022
0xdef1cafe
reviewed
Jun 29, 2022
0xApotheosis
previously approved these changes
Jun 30, 2022
gomesalexandre
added a commit
that referenced
this pull request
Jul 14, 2022
This reverts commit f304b4f.
0xdef1cafe
added a commit
that referenced
this pull request
Jul 18, 2022
* wip * wip * wip * Revert "fix: make web great again (#2145)" This reverts commit 64d0631. * wip * wip * feat: match design * Revert "feat: switch chain to mainnet on wallet re/connect (#2085)" This reverts commit f304b4f. * feat: style improvements, add current chain icon * chore: PR cleanup * chore: add comment about optimistic switch * feat: improve chain-adapters-getting logic * chore: trigger CI * chore: update yarn.lock * feat: tackle self-review comments * chore: remove MM and XDEFI wrong network translations * chore: naming nitpicks * feat: semantic improvements, make supportedEvmChainIds a memoized expression * chore: chainId: string -> chainId: ChainId * fix: don't show chain switch menu if there's only one change * feat: bump @shapeshiftoss/chain-adapters to latest to automagically switch EVM chains on buildSendTransaction() * chore: don't optional chain nativeAsset.icon * chore: as any -> as ETHWallet Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This switches the wallet's active chain to Ethereum Mainnet if set to any other chain, on wallet connect from splash screen / wallet reconnect when reloading the app.
Notice
Pull Request Type
Issue (if applicable)
Risk
None - this is isolated to MetaMask, XDEFI and TallyHo. If the wallet is set to Mainnet, the flow will continue as before.
Testing
Wallet Connect from splash screen
App reload
Screenshots (if applicable)