Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal to sign message for Wallet Connect #2717

Conversation

southbears
Copy link
Contributor

@southbears southbears commented Sep 12, 2022

Description

This PR is for the layout of the Wallet Connect modal to sign a message. Note that I'm using dummy data for now. This is hidden behind a feature flag, so won't impact users. I'm trying to break down the work into smaller, easier to review, incremental steps (also helps with my own sanity)

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

related to https://app.dework.xyz/profile/southbear/board?taskId=e05da789-5f4d-4362-bfcc-129865df903a

Risk

Hidden behind feature flag

Testing

Enable the wallet connect feature flag and click the header button with the label "WC"

Engineering

Operations

Screenshots (if applicable)

image

@southbears southbears requested a review from a team as a code owner September 12, 2022 21:42
@southbears southbears mentioned this pull request Sep 12, 2022
4 tasks
mb={4}
/>
<WalletSummaryCard
address='0x03ed759b696b62774D02156a189F6E176C15b3a3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy data

</HStack>
</ModalHeader>
<SignMessageConfirmation
message='Message to sign...'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy data

</Link>
</HStack>
<RawText color='gray.500' fontWeight='medium'>
Balance: {balance} ETH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy data

@0xdef1cafe
Copy link
Collaborator

closing in favor of #3140

@0xdef1cafe 0xdef1cafe closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants