Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalidated translations script typing #4225

Merged
merged 2 commits into from Apr 11, 2023
Merged

fix: invalidated translations script typing #4225

merged 2 commits into from Apr 11, 2023

Conversation

firebomb1
Copy link
Contributor

Description

Adds missing typing for a function in the TypeScript used to manually invalidate the translations. The script cannot run without it since 1e3429b

Notice

  • Have you followed the guidelines in our Contributing guide?
  • [ x Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Risk

None.

Testing

No testing required.

Engineering

Operations

Screenshots (if applicable)

@firebomb1 firebomb1 requested a review from a team as a code owner April 11, 2023 10:32
@firebomb1 firebomb1 self-assigned this Apr 11, 2023
gomesalexandre
gomesalexandre approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed this fixes the remove-outdated-translations script 💯

@gomesalexandre gomesalexandre enabled auto-merge (squash) April 11, 2023 13:54
@gomesalexandre gomesalexandre merged commit c59e9f7 into shapeshift:develop Apr 11, 2023
3 checks passed
@0xdef1cafe 0xdef1cafe mentioned this pull request Apr 11, 2023
Merged
@firebomb1 firebomb1 deleted the fix-translation-script branch April 11, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees

@firebomb1 firebomb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@firebomb1 @gomesalexandre