Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade typescript to 4.5.2 #477

Merged
merged 2 commits into from
Nov 30, 2021
Merged

chore: upgrade typescript to 4.5.2 #477

merged 2 commits into from
Nov 30, 2021

Conversation

cjthompson
Copy link
Contributor

Description

chore: upgrade typescript to 4.5.2 (was 4.4.4)

Notice

Before submitting a pull request, please make sure you have answered the following:

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Do all new and existing tests pass? Does the linter pass?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

@cjthompson cjthompson requested a review from a team as a code owner November 19, 2021 18:53
@vercel
Copy link

vercel bot commented Nov 19, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/web/CpctJk3D1nkNMBKFcjpzH4HqE7XK
✅ Preview: https://web-git-upgrade-typescript-shapeshift.vercel.app

@cjthompson cjthompson marked this pull request as draft November 19, 2021 19:11
@mrnerdhair mrnerdhair marked this pull request as ready for review November 24, 2021 18:29
cjthompson
cjthompson commented Nov 24, 2021
View reviewed changes
Copy link
Contributor Author

@cjthompson cjthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume all tests are passing and the build completes?

@mrnerdhair
Copy link
Contributor

I assume all tests are passing and the build completes?

yepperooni!

@0xdef1cafe 0xdef1cafe merged commit 92af8da into develop Nov 30, 2021
@0xdef1cafe 0xdef1cafe deleted the upgrade-typescript branch November 30, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnerdhair mrnerdhair mrnerdhair approved these changes

@0xdef1cafe 0xdef1cafe 0xdef1cafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjthompson @mrnerdhair @0xdef1cafe