Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: language selector on connect page #4908

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat: language selector on connect page #4908

merged 3 commits into from
Jul 11, 2023

Conversation

firebomb1
Copy link
Contributor

@firebomb1 firebomb1 commented Jul 10, 2023 •
edited

Description

  • Adds a language selector dropdown menu on the top right of the Connect page. For cases where the language detection fails/is not accurate, allows the user to choose their language from the start.
  • Adds tracking for that language selector under the Click event element Language Selector and records the selected language in the selectedLanguage property.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Low. Adds an element on the Connect page, so test for visual changes.

Testing

  • Access the Connect page as a first time user or existing user and verify that the default language or user's lanague is selected.
  • Attempt to change the language and connect, language must be preserved based on the user's selection.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

Desktop resolution:
image
Mobile (default detection to French (Français):
image
Mobile while changing language:
image
Mobile after consent and language change to English:
image
Mobile landscape:
image

@firebomb1 firebomb1 self-assigned this Jul 10, 2023
@firebomb1 firebomb1 added the needs product Requires product input before bounty label Jul 10, 2023
@firebomb1 firebomb1 marked this pull request as ready for review July 11, 2023 03:06
@firebomb1 firebomb1 requested a review from a team as a code owner July 11, 2023 03:06
@firebomb1 firebomb1 removed the needs product Requires product input before bounty label Jul 11, 2023
@firebomb1
Copy link
Contributor Author

Discussed and approved by @twblack88 in DM.

gomesalexandre
gomesalexandre approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed this does what it says on the box and Mixpanel is happy 🌯

@gomesalexandre gomesalexandre enabled auto-merge (squash) July 11, 2023 16:12
@gomesalexandre gomesalexandre merged commit 74c7883 into develop Jul 11, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the feat-language-selector branch July 11, 2023 16:18
@0xApotheosis 0xApotheosis mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees

@firebomb1 firebomb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@firebomb1 @gomesalexandre