Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset page oops #5808

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: asset page oops #5808

merged 1 commit into from
Dec 7, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 7, 2023 •
edited

Description

(maybe?)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes N/A

Risk

None, can't break what's broken - we need Suspense here either way

Testing

  • None - not a guaranteed fix but we need this

Engineering

Operations

  • ☝🏽

Screenshots (if applicable)

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review December 7, 2023 22:24
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 7, 2023 22:24
reallybeard
reallybeard approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@reallybeard reallybeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go!!

@0xApotheosis 0xApotheosis self-assigned this Dec 7, 2023
0xApotheosis
0xApotheosis reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this PR doesn't make it any worse, but I still get it almost every time :(

Screenshot 2023-12-08 at 9 41 48 am

0xApotheosis
0xApotheosis approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, this is better than we had before - get 'er in.

@0xApotheosis 0xApotheosis merged commit 79557eb into develop Dec 7, 2023
3 checks passed
@0xApotheosis 0xApotheosis deleted the fix_woopsie branch December 7, 2023 22:44
@gomesalexandre gomesalexandre mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reallybeard reallybeard reallybeard approved these changes

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees

@0xApotheosis 0xApotheosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gomesalexandre @reallybeard @0xApotheosis