feat: use loading state on multi-hop trade confirm button #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
3 tasks
woodenfurniture
force-pushed
the
multi-hop-loading-state
branch
from
8a06273
to
e40b250
Compare
3 tasks
gomesalexandre
approved these changes
Dec 8, 2023
woodenfurniture
force-pushed
the
multi-hop-loading-state
branch
from
e40b250
to
113fabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ability to proceed with a trade while approval requirements are still being fetched by applying a loading state to the button until everything is initialized.
Pull Request Type
Issue (if applicable)
NA
Risk
Not production facing - low risk.
Testing
Not required.
Engineering
Operations
Screenshots (if applicable)
Loading state while approvals are being checked
Once approvals are loaded, loading state is cleared
