Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move types from swapper #5826

Merged
merged 6 commits into from
Dec 11, 2023
Merged

chore: move types from swapper #5826

merged 6 commits into from
Dec 11, 2023

Conversation

0xApotheosis
Copy link
Contributor

Description

Moves types out of lib/swapper and into @shapeshiftoss/swapper.

Pull Request Type

  • ๐Ÿ› Bug fix (Non-breaking Change: Fixes an issue)
  • ๐Ÿ› ๏ธ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • ๐Ÿ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Contributes to #5739

Risk

Small, if this compiles and goes green it should be ok, but a general regression test is needed.

Testing

This should in theory be a refactor, so only a general regression test is needed.

Engineering

โ˜๏ธ

Operations

โ˜๏ธ

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner December 11, 2023 08:19
@gomesalexandre gomesalexandre enabled auto-merge (squash) December 11, 2023 10:30
@gomesalexandre gomesalexandre merged commit 3c3db59 into develop Dec 11, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the swapper-package-3 branch December 11, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants