feat: add fallback doge transaction fee #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodenfurniture
approved these changes
Dec 13, 2023
woodenfurniture
force-pushed
the
hardcode-doge-fee
branch
from
1f4553f
to
1208d76
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a special case when calculating the network fees for DOGE to fallback on a hardcoded
satoshiPerBytevalue that is high enough to go through (the number is a little over double the current "fast" value).Note, https://api.dogecoin.shapeshift.com/api/v1/fees seems to be working fine now, so it won't actually change behaviour right now.
Pull Request Type
Issue (if applicable)
Closes #5822
Risk
Small - user could pay more DOGE in transactions fees if this is not implemented correctly.
Testing
Not currently possible without intercepting the response to https://api.dogecoin.shapeshift.com/api/v1/fees
Engineering
Sanity check logic.
Operations
DOGE sends should work.
Screenshots (if applicable)
N/A