fix: add a loading state to the asset dropdown #5846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the ability to open the asset selection modal/dropdown while assets are still being loaded, resulting in an empty list. The solution was to trigger the build-in loading state to the button while assets are loading.
Pull Request Type
Issue (if applicable)
NA
Risk
Low risk.
Testing
check asset selection still works
check loading state stops when app is loaded (this may happen too quickly to see if your internet connection is fast)
Engineering
Operations
Screenshots (if applicable)
Loading state look like this