Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a loading state to the asset dropdown #5846

Merged
merged 2 commits into from Dec 13, 2023

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Dec 13, 2023

Description

Fixes the ability to open the asset selection modal/dropdown while assets are still being loaded, resulting in an empty list. The solution was to trigger the build-in loading state to the button while assets are loading.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

NA

Risk

Low risk.

Testing

check asset selection still works
check loading state stops when app is loaded (this may happen too quickly to see if your internet connection is fast)

Engineering

Operations

Screenshots (if applicable)

Loading state look like this
image

@woodenfurniture woodenfurniture requested a review from a team as a code owner December 13, 2023 03:02
@woodenfurniture
Copy link
Member Author

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM:

  • Borrow
borrow.mov
  • Repayment
repayment.mov
  • Swapper
trade.mov

@gomesalexandre gomesalexandre enabled auto-merge (squash) December 13, 2023 11:33
@gomesalexandre gomesalexandre merged commit dbbd6c4 into develop Dec 13, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the fix-asset-dropdown-loading-state branch December 13, 2023 11:38
gomesalexandre added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants