feat: thorchain lp consistent base values over percent change #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
gomesalexandre
commented
Jan 16, 2024
| } | ||
|
|
||
| if (timeframe === 'all') { | ||
| const genesis = '1647907200' |
There was a problem hiding this comment.
0xApotheosis
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure we use the same reference data points for base (a.k.a absolute, current, now), making data more accurate, and consequently percent change as well.
Pull Request Type
Issue (if applicable)
follows-up closed #5939
Risk
Overfetching, which will need to be tackled holistically
Testing
Engineering
Operations
Screenshots (if applicable)