Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic add liquidity wire-up #6023

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 16, 2024

Description

This PR does a basic wire-up of THORCHain LP add liquidity - also brings the notion of handling sym/asym differently at view-layer time by displaying one or both assets.

Note, this does not yet wire-up the standalone "Add Liquidity" component, which will be slightly different because of the notion of pool selection.
This also does not wire-up amounts, as these will be coming from confirmed/quote from react-query, which we don't have yet.

  • Deposit Amounts should match the asym type (or sym)
  • This guy should be displayed programatically only in the case of asym, and iwth the right asset being displayed Your <asset> will be split into a 50:50 exposure to both <asset2> and <asset> upon entering the pool.
  • Standalone isn't borked and allows selection Not for this PR
  • Wire-up confirm
  • Wire-up status

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

None, this isn't live yet, and many things are either unknown or very likely to change here

Testing

  • Wiring up of displayed assets looks sane
  • Discrimination of sym/asym looks sane at view-layer time, with the right components displayed depending on the a/sym type i.e either one, the other, or both

Engineering

Operations

Screenshots (if applicable)

Asset asym

image image image

RUNE asym

image image image

Symmetrical

image image image

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre changed the title feat: basic add deposit wire-up feat: basic add liquidity wire-up Jan 16, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review January 16, 2024 23:19
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 16, 2024 23:19
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says (can click around) and well implemented. Let's get this in for progress 🚀

@0xApotheosis 0xApotheosis merged commit 75a31c0 into develop Jan 17, 2024
4 checks passed
@0xApotheosis 0xApotheosis deleted the wip_wire_up_add_liquidity branch January 17, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants