Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: atom trades using incorrect message type #6024

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Jan 17, 2024

Description

Fixes broken trades from atom due to incorrect message type being attached to the transaction.

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5995

Risk

Risk that trades from atom are still broken

Testing

Check trades from atom are working

Engineering

Operations

Screenshots (if applicable)

Send request at start of transaction was successful (was http 500 previously):
image

Trade succeeded:
image

@woodenfurniture woodenfurniture requested a review from a team as a code owner January 17, 2024 00:57
@woodenfurniture
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xApotheosis 0xApotheosis merged commit 78b0b80 into develop Jan 17, 2024
4 checks passed
@0xApotheosis 0xApotheosis deleted the fix-atom-trades branch January 17, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atom to Rune trade failing
2 participants