Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove liquidity #6031

Merged
merged 8 commits into from
Jan 23, 2024
Merged

feat: remove liquidity #6031

merged 8 commits into from
Jan 23, 2024

Conversation

reallybeard
Copy link
Contributor

@reallybeard reallybeard commented Jan 17, 2024 •
edited

Description

  • The remove liquidity input
  • Placeholder routes for confirm and status

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5958

Risk

High Risk PRs Require 2 approvals

Testing

Engineering

Operations

Screenshots (if applicable)

Screenshot 2024-01-23 at 3 06 51 PM

@reallybeard reallybeard marked this pull request as ready for review January 23, 2024 21:06
@reallybeard reallybeard requested a review from a team as a code owner January 23, 2024 21:06
gomesalexandre
gomesalexandre approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM! Stamping so we can get this moving as view-layer only

@gomesalexandre gomesalexandre enabled auto-merge (squash) January 23, 2024 22:37
@gomesalexandre gomesalexandre merged commit 8079ee0 into develop Jan 23, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_remove_liquidity_ui branch January 23, 2024 22:40
@0xApotheosis 0xApotheosis mentioned this pull request Jan 24, 2024
Merged
0xApotheosis pushed a commit that referenced this pull request Jan 24, 2024
@reallybeard @0xApotheosis
feat: remove liquidity (#6031)
7693a85
This was referenced Jan 24, 2024
Merged
Merged
@gomesalexandre gomesalexandre mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI component for rem liquidity
2 participants
@reallybeard @gomesalexandre