Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ledger cosmos support #6054

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: ledger cosmos support #6054

merged 4 commits into from
Jan 23, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 22, 2024 •
edited

Description

Adds Cosmos support for Ledger

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes shapeshift/hdwallet#655

Risk

High Risk PRs Require 2 approvals

Low but not none, ensure Cosmos on Ledger works as expected similar to other chains on Ledger across all domains (savers, sends, swaps..)

Testing

  • See risks

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Chain accounts connection
image
  • Account 0
image
  • Account 1
image
  • Self-send
image
  • Native staking deposit
image image image
  • Native staking withdraw
image image image
  • Savers deposit
image image image image
  • Savers withdraw
image image image image

Swaps

image image image image image image image

@gomesalexandre gomesalexandre requested a review from a team as a code owner January 22, 2024 16:24
@gomesalexandre gomesalexandre marked this pull request as draft January 22, 2024 16:24
@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre mentioned this pull request Jan 23, 2024
Merged
@gomesalexandre gomesalexandre marked this pull request as ready for review January 23, 2024 19:07
kaladinlight
kaladinlight approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@kaladinlight kaladinlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@gomesalexandre gomesalexandre enabled auto-merge (squash) January 23, 2024 19:10
@gomesalexandre gomesalexandre merged commit 7ee27f4 into develop Jan 23, 2024
4 checks passed
@gomesalexandre gomesalexandre deleted the feat_ledger_cosmos branch January 23, 2024 19:12
This was referenced Jan 24, 2024
Merged
Merged
0xApotheosis pushed a commit that referenced this pull request Jan 24, 2024
@gomesalexandre @0xApotheosis
feat: ledger cosmos support (#6054)
d7678f6
@0xApotheosis 0xApotheosis mentioned this pull request Jan 25, 2024
Merged
0xApotheosis pushed a commit that referenced this pull request Jan 25, 2024
@gomesalexandre @0xApotheosis
feat: ledger cosmos support (#6054)
ef901b8
@gomesalexandre gomesalexandre mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ATOM support for Ledger
2 participants
@gomesalexandre @kaladinlight