Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add longtail source UI #6056

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

0xApotheosis
Copy link
Contributor

Description

Add longtail tags in UI:

Screenshot 2024-01-23 at 11 24 42β€―am

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A - small swapper improvement.

Risk

Small, some regression risk with labels and TX links.

Testing

  • Check that quotes for longtail swaps show the correct labels, and that the confirm/execute screens correctly show the trade source.
  • Check that TX links still works as expected.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

See description.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 23, 2024 00:29
@0xApotheosis 0xApotheosis changed the base branch from develop to amountOutMin January 23, 2024 00:29
@woodenfurniture woodenfurniture self-assigned this Jan 23, 2024
@woodenfurniture woodenfurniture merged commit 33a707c into amountOutMin Jan 23, 2024
@woodenfurniture woodenfurniture deleted the add-longtail-source-tags branch January 23, 2024 00:46
0xApotheosis added a commit that referenced this pull request Jan 23, 2024
* fix: add amountOutMin

* fix: active pool status

* fix: handle decimal percentage

* chore: enable longtail feature flag

* chore: address review feedback

* chore: paranoia assertion

* chore: keep longtail off for now

* chore: address review feedback

* chore: remove typo

* feat: add longtail source UI (#6056)

feat: add longtail source ui
@0xApotheosis 0xApotheosis mentioned this pull request Jan 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants