Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream status displayed for non THOR streaming swaps #6059

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 23, 2024

Description

Fixes "Stream Status" progress bar being displayed for all swaps instead of streaming swaps only

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A, this wasn't captured as an issue but spotted in #6051

Risk

High Risk PRs Require 2 approvals

  • Low to none - we can ensure streaming swaps still have "Stream Status" displayed as a paranoia check, though if we can't test this because of funds required for streaming swaps testing, this has effectively 0 risk

Testing

  • Non-streaming swaps do not have "Stream Status" displayed at swap progress and complete steps

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Develop

Screenshot 2024-01-23 at 14 24 04 Screenshot 2024-01-23 at 14 24 04

This diff

image image

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review January 23, 2024 13:26
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 23, 2024 13:26
@gomesalexandre gomesalexandre merged commit 427b28a into develop Jan 23, 2024
4 checks passed
@gomesalexandre gomesalexandre deleted the fix_streaming_swaps branch January 23, 2024 17:35
@gomesalexandre gomesalexandre mentioned this pull request Jan 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants