fix: receive amount on confirm screen #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodenfurniture
approved these changes
Jan 24, 2024
0xApotheosis
added a commit
that referenced
this pull request
Jan 24, 2024
0xApotheosis
added a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the receive amount on the confirm screen showing the before fees receive amount, instead of the after fees receive amount we show on the quote screen.
Pull Request Type
Issue (if applicable)
Closes #6065
Risk
Small
Testing
For all swaps, particularly those using THORChain, the amount shown on on the quote screen should match the amount shown on the confirm screen.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Note that the values now match: