Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide APY and show expired tag for expired opportunities #6083

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 25, 2024

Description

Does what it says on the box - apprends an "Ended" tag instead of prepending the APR for expired opportunities

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6071, unless @reallybeard wants to oil some expiration time in here

Risk

High Risk PRs Require 2 approvals

None, if this looks good, we're good

Testing

  • Connect using the demo wallet
  • Ensure old FOX Farming opportunities are properly tagged as ended, with no APR shown

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Develop
Screenshot 2024-01-25 at 16 32 56
  • This diff
image

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review January 25, 2024 15:45
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 25, 2024 15:45
@reallybeard
Copy link
Contributor

Looks good to me!

@gomesalexandre gomesalexandre merged commit a59cbfc into develop Jan 25, 2024
7 checks passed
@gomesalexandre gomesalexandre deleted the feat_hide_apy_expired branch January 25, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V7 farming rewards showing APR after rewards expiration
3 participants