fix: quote loading state #6088
Merged
fix: quote loading state #6088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/MultiHopTrade/hooks/useGetTradeQuotes/useGetTradeQuotes.tsx
Outdated
Show resolved
Hide resolved
0xApotheosis
added a commit
that referenced
this pull request
Jan 30, 2024
This reverts commit 04574b8.
3 tasks
woodenfurniture
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the quote loading state so we don't show "No rate available" while we are still looking for quotes.
Develop:
develop.mp4
This branch:
branch.mp4
Note, we still get a small flash of "No rate available", but that is not intended to be fixed in this PR.
Pull Request Type
Issue (if applicable)
N/A
Risk
Small
Testing
The issue usually occurs when fetching the first quote after a refresh/initial load.
Get a quote and confirm the loading state shows for the rate whilst the quotes are loading.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A