fix: nullish coalescing in lending memo #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
May 3, 2024
gomesalexandre
changed the title
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regression in #6755 where
undefinedwas present in the memo for savers withdraws and deposits, which cannot be parsed by THORChain.Pull Request Type
Issue (if applicable)
N/A
Risk
Theoretically high as it touches memos, but practically low as it fixes a known issue.
Thorchain savers deposits and withdraw.
Testing
Complete a savers deposit or withdraw and confirm that the
minOutfield of the memo is an empty string and notundefined.Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A