Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safari issue #11

Closed
YongjunKang opened this issue May 16, 2022 · 1 comment
Closed

safari issue #11

YongjunKang opened this issue May 16, 2022 · 1 comment

Comments

@YongjunKang
Copy link

스크린샷 2022-05-16 오후 6 20 45

After adding bundles to the project, the corresponding error occurs randomly when testing with safari.

When I unpacked and read the code in the walk.min.js, I found that '_asyncPropertiesDetectionListeners' code was not defined anywhere.

    this.onAsyncPropertiesDetected = function (h) {
      void 0 !== e.webp ? h() : this._asyncPropertiesDetectionListeners.push(h);
    };

I changed the code as below. The error has been resolved.

    this.onAsyncPropertiesDetected = function (h) {
      h();
    };

Is the code a problem?
It may not be accurate by referring to the translator.

@wmatyjewicz
Copy link
Member

wmatyjewicz commented May 16, 2022

Thanks for the detailed report! We’ve identified the issue and implemented a fix. For scenes hosted on our infrastructure a viewer update with the fix will be rolled out this week. For bundling the fix will be included in the release of the Shapespark.

If you need to apply the fix for the bundles before the release, modify the code in the following way:

    this.onAsyncPropertiesDetected = function (h) {
      void 0 !== e.webp ? h() : _asyncPropertiesDetectionListeners.push(h);
    };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants