Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common components for input forms instead of custom html #160

Closed
shapiromatron opened this issue Sep 28, 2021 · 1 comment
Closed

common components for input forms instead of custom html #160

shapiromatron opened this issue Sep 28, 2021 · 1 comment
Assignees

Comments

@shapiromatron
Copy link
Owner

Instead of using raw html for select and input components, use some predefined components to standardize the user-interface

  • use the existing components/common/SelectInput; modify as needed to work
  • use the existing components/common/FloatInput; modify as needed to work
  • create and use components/common/IntegerInput
  • create and use components/common/TextInput
  • create and use components/common/CheckboxInput if this make sense (but only if it makes sense; I know the model selection items ones are already heavily componentized so they may be fine as is)
  • create and use components/common/LabelInput if this make sense

Migrate from custom html to these components. It's ok to not migrate over very customized inputs if needed, but we should default to using the components when possible.

@shapiromatron shapiromatron changed the title form input refactorings use common components for input forms instead of custom html Sep 28, 2021
@shapiromatron shapiromatron changed the title use common components for input forms instead of custom html common components for input forms instead of custom html Sep 28, 2021
@shapiromatron
Copy link
Owner Author

Closed by #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants