Code refactoring of inputs tag #161
Conversation
|
@shapiromatron ready for review. on the data page, when using the select input tag, there was a css issue. i will continue to work on figuring out the best way. right now its consuming more time so i just left it like it was earlier. |
There was a problem hiding this comment.
@shapiromatron ready for review. on the data page, when using the select input tag, there was a css issue. i will continue to work on figuring out the best way. right now its consuming more time so i just left it like it was earlier.
Ok, please fix and let me know when you're ready for me to check and look around; right now I just reviewed the code.
A few changes to make our components consistent.
frontend/src/components/Main/DatasetModelOptionList/DatasetModelOption.js
Outdated
Show resolved
Hide resolved
|
@shapiromatron please review FloatInput.js , i just used in simple way. the only problem i see is when the input box is empty it gives warning about Nan, but when its filled it goes away. i dont think it will cause any error. we can discuss. i tried to migrate most of the html inputs to the react components. happy to receive any input. |
There was a problem hiding this comment.
Looking good. I made a number of changes, but one of the more substantial ones was the LabelInput. One of the key attributes on the label is the for, or htmlFor in react. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
The way it initially implemented in this PR, a new ID was created for the label and the other component, so if a user clicked a label, it wouldn't go to the desired input. This has been fixed.
I also added a TextAreaComponent in the spirit of this PR.
shapiromatron
changed the title
Implemented #161