Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary.Visual image options #1008

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Add summary.Visual image options #1008

merged 4 commits into from
Mar 13, 2024

Conversation

shapiromatron
Copy link
Owner

Add image options to summary visuals, after noticing some high resolution pixels scale and look way too big for a screen.

Added two new options when configuring a summary image:

  • alt-text (required): text required to display on image for accessibility purposes
  • max_width (optional; default 1000px) - if specified, the maximum width of an image. If unspecified, it will grow to 100% of the image width in pixels. The image now auto-shrinks on mobile views too.

Example; max width of 600px:
image

And a mobile view of 400px wide:
image

@shapiromatron shapiromatron changed the title Add image options Add summary.Visual image options Mar 13, 2024
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, it just needed formatting for the HTML changes

@shapiromatron shapiromatron merged commit cf1db3b into main Mar 13, 2024
6 checks passed
@shapiromatron shapiromatron deleted the image-options branch March 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants