Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit review summary page #752

Merged
merged 13 commits into from
Jan 11, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Dec 10, 2022

Updates literature review page to reflect new conflict resolution models & stats.

  • Includes a potential visual rework for funsies. Can be easily reverted to existing table view if preferred (while including new stats)
  • Clicking a tile will redirect to a filtered list view matching the stat (if possible)
  • potential for more graphs

image
image

  • Works without conflict resolution too
    image

@caseyhans caseyhans changed the base branch from main to literature-conflict-resolution December 10, 2022 02:42
@shapiromatron shapiromatron changed the title Lit review rework Lit review summary page Dec 12, 2022
@shapiromatron shapiromatron removed their request for review December 16, 2022 18:26
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! I made some changes, but nothing huge:

  • fix error w/ unauthenticated users
  • create utility classes for widths instead of putting into the main class
  • reorganized the forms for vertical space
  • tried to provide a pydantic default instead of handling multiple types (eg., provide an empty string instead of Optional[str])

@shapiromatron shapiromatron merged commit 8c22ae3 into literature-conflict-resolution Jan 11, 2023
@shapiromatron shapiromatron deleted the lit-review-rework branch January 11, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants