Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment admin notes #763

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Assessment admin notes #763

merged 4 commits into from
Jan 17, 2023

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented Jan 9, 2023 •
edited

Added an admin_notes field to the Assessment model. As the name implies this field is meant for admins only, so as such it is not viewable or editable anywhere besides the admin dashboard.

Admin assessment detail view

image

@rabstejnek rabstejnek marked this pull request as ready for review January 9, 2023 14:42
shapiromatron
shapiromatron approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tweaked the help text, but checked all APIs and code paths to confirm field was only shown in the admin.

@shapiromatron shapiromatron merged commit 7fa0343 into main Jan 17, 2023
@shapiromatron shapiromatron deleted the assessment-admin-notes branch January 17, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

@swatford swatford Awaiting requested review from swatford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rabstejnek @shapiromatron