rewrite epiv2 exports #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabstejnek
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Looking good! There were some commented TODOs left in here that I think should be addressed before merge, which makes up the bulk of the comments I left. Also once those are wrapped up you should regenerate the VCR fixture for the epi api test so that it passes.
shapiromatron
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
LGTM! I made two minor changes, if you're ok with these. I figure in the future we'll get rid of the FlatFileExporter and just use this Export class directly; you can see I was able to do so in the epiv2 api (but couldn't get rid of it b/c the DataPivotQuery still uses the old one).
rabstejnek
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite how the epiv2 export is calculated to combine multiple django ORM queries into a single request.
No changes were made to the export format of the data itself.
This PR created two new base classes,
ModelExport, andExporter, that we'll use throughout the application to update our modernize our existing export formats.