Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reference list view component #878

Merged
merged 19 commits into from Sep 8, 2023
Merged

update reference list view component #878

merged 19 commits into from Sep 8, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Aug 14, 2023

This PR primarily focuses on refining the UI for the reference react component and html fragment.

Other changes include:

  • Regex escaping for reference keyword highlighting to fix bugs from lists with parentheses, square brackets, etc.
  • Reference tags are smaller with greater margins for better readability + compression
  • Moved EPA button styles from epa-hawc.css to hawc.css to maintain button sizing across versions
  • New CSS classes:
    • btn-tny for buttons smaller than btn-sm
    • outline-btn for clear buttons with gray border
    • clickable class now includes a brief animation on background color change
    • vw75 sets a max width of 75vw (75% of viewport width)

Reference Changes

Javascript component

Before

image

After: default view, abstract compressed, using new button classes

image

After: clicking on abstract text expands it into a scrollable view

image

HTML fragment

Before

image

After

image

Other changes

Update reference tag sizing and margins to improve readability

Before: conflict resolution view

image

After: conflict resolution view

image

Before: tagging view

image

After: tagging view

image

Update tagtree selection/hover style

Before

image

After

image

Prime button styles now match EPA for consistency

Before

image

After

image

@caseyhans caseyhans marked this pull request as ready for review August 16, 2023 20:50
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I'm really excited about these changes. Things look much better. Nice job!

I made a number of minor revisions; might want to browse the diffs to make sure you're ok with changes:

  • f9639a9 css updates
  • c16a08b open external links in new tabs; internal in same tab
  • ca4fcfb add journal to django reference template
  • 3d725d8 rename Imports to Source (may be search)
  • 0d140a0 fix actions button on modal list

PS - nifty git command to build the list above :

git log -n 8 --format="* %h %s"

@caseyhans caseyhans merged commit 5970ded into main Sep 8, 2023
3 checks passed
@caseyhans caseyhans deleted the update-ref-comp branch September 8, 2023 22:28
@shapiromatron shapiromatron changed the title update reference component update reference list view component Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants