New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update reference list view component #878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I'm really excited about these changes. Things look much better. Nice job!
I made a number of minor revisions; might want to browse the diffs to make sure you're ok with changes:
- f9639a9 css updates
- c16a08b open external links in new tabs; internal in same tab
- ca4fcfb add journal to django reference template
- 3d725d8 rename Imports to Source (may be search)
- 0d140a0 fix actions button on modal list
PS - nifty git command to build the list above :
git log -n 8 --format="* %h %s"
shapiromatron
changed the title
update reference component
update reference list view component
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily focuses on refining the UI for the reference react component and html fragment.
Other changes include:
btn-tny
for buttons smaller than btn-smoutline-btn
for clear buttons with gray borderclickable
class now includes a brief animation on background color changevw75
sets a max width of 75vw (75% of viewport width)Reference Changes
Javascript component
Before
After: default view, abstract compressed, using new button classes
After: clicking on abstract text expands it into a scrollable view
HTML fragment
Before
After
Other changes
Update reference tag sizing and margins to improve readability
Before: conflict resolution view
After: conflict resolution view
Before: tagging view
After: tagging view
Update tagtree selection/hover style
Before
After
Prime button styles now match EPA for consistency
Before
After