Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create user defined forms app #882

Merged
merged 39 commits into from Sep 18, 2023
Merged

create user defined forms app #882

merged 39 commits into from Sep 18, 2023

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Aug 28, 2023 •
edited

Creates the basic structure for creating custom forms for the form library.

  • Adds necessary files from the dynamic forms implementation in LLR, including tests
  • Adds a new app called 'form_library' which contains the models/views for creating custom forms (use feature flag ENABLE_DYNAMIC_FORMS to access the new app)

@munnsmunns munnsmunns marked this pull request as ready for review August 29, 2023 21:18
shapiromatron
shapiromatron requested changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of changes with some potentially painful renaming requests, but hopefully nothing too terrible! Looks like a great start!

Let me know if you need help w/ any of the changes or if any will be prohibitively time consuming.

hawc/apps/form_library/forms.py Outdated Show resolved Hide resolved
hawc/apps/form_library/models.py Outdated Show resolved Hide resolved
hawc/apps/common/dynamic_forms/fields.py Outdated Show resolved Hide resolved
hawc/apps/common/dynamic_forms/forms.py Outdated Show resolved Hide resolved
hawc/apps/form_library/models.py Outdated Show resolved Hide resolved
hawc/apps/form_library/models.py Outdated Show resolved Hide resolved
hawc/main/urls.py Outdated Show resolved Hide resolved
hawc/apps/form_library/migrations/__init__.py Outdated Show resolved Hide resolved
tests/hawc/apps/common/dynamic_forms/test_schemas.py Outdated Show resolved Hide resolved
hawc/apps/form_library/urls.py Outdated Show resolved Hide resolved
@shapiromatron
Copy link
Owner

@munnsmunns - would you mind resolving any threads above that have been handled in the changes?

@shapiromatron shapiromatron changed the base branch from refactor-prefilters to main September 16, 2023 13:36
@shapiromatron shapiromatron mentioned this pull request Sep 16, 2023
Merged
@shapiromatron shapiromatron changed the base branch from main to dynamic-forms September 16, 2023 14:10
@shapiromatron
Merge branch 'dynamic-forms' into form-library
848f016 
# Conflicts:
#	hawc/apps/common/filterset.py
#	hawc/apps/summary/forms.py
#	hawc/apps/summary/models.py
#	hawc/apps/summary/serializers.py
#	tests/data/api/api-visual-bioassay-aggregation.json
#	tests/data/api/api-visual-crossview.json
#	tests/data/api/api-visual-embedded-tableau.json
#	tests/data/api/api-visual-exploratory-heatmap.json
#	tests/data/api/api-visual-rob-barchart.json
#	tests/data/api/api-visual-rob-heatmap.json
#	tests/data/api/api-visual-tagtree.json
@shapiromatron
fix merge conflicts
aa4caba
@shapiromatron
revert db fixture
9500b80
@shapiromatron
use regex
99660b4
@shapiromatron
remove ID
3c3e384
@shapiromatron
rename to udf
59ae0d4
@shapiromatron
lint; add test UDF to db schema
2978b32
@shapiromatron
dont hard-code model related models
f853b49
@shapiromatron
validate field name via regex
f7ea9c4
@shapiromatron
Merge branch 'dynamic-forms' into form-library
deb5d97
munnsmunns
munnsmunns commented Sep 18, 2023
View reviewed changes
Copy link
Collaborator Author

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, seems totally sensible to me

Base automatically changed from dynamic-forms to main September 18, 2023 19:46
@shapiromatron shapiromatron changed the title create dynamic form library create user defined forms app Sep 18, 2023
@shapiromatron shapiromatron merged commit 9954ef1 into main Sep 18, 2023
3 checks passed
@shapiromatron shapiromatron deleted the form-library branch September 18, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

@rabstejnek rabstejnek Awaiting requested review from rabstejnek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munnsmunns @shapiromatron @rabstejnek