New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icf create epi v2 client #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks close! A few minor updates, plus a new field added in #902
fixing formatting issues, handling adverse_direction, etc.
running black from a subdir. I do have Vim integration with it which has worked in the past but maybe that is misconfigured, I'll mess with that a bit. last update -- hopefully my editor integration fixed now and won't come up again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work.
Add client operations to CRUD epiv2, and required tests.