Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data pivot file upload form javascript #894

Merged
merged 3 commits into from Sep 13, 2023
Merged

Conversation

rabstejnek
Copy link
Collaborator

There was a bug in the Django template for the data pivot file upload form that was breaking the javascript that added auto-slugification and quillified the caption field. This PR fixes it by adding a default value when declaring the javascript variables instead of having the template leave the declared value blank.

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One proposed change to simplify template - nice job finding root-cause

@rabstejnek rabstejnek merged commit e8cfd05 into main Sep 13, 2023
3 checks passed
@rabstejnek rabstejnek deleted the dp-file-form-fix branch September 13, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants